yuqi1129 commented on code in PR #6214:
URL: https://github.com/apache/gravitino/pull/6214#discussion_r1917810911
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java:
##########
@@ -588,6 +596,16 @@ public void testConnection(
}
}
+ private static Distribution getIcebergDefaultDistribution(
+ Boolean isSorted, Boolean isPartitioned) {
Review Comment:
Boolean -> boolean
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java:
##########
@@ -513,6 +514,13 @@ public Table createTable(
.build())
.toArray(IcebergColumn[]::new);
+ // Gravitino NONE distribution means the client side doesn't specify
distribution not the same
Review Comment:
distribution not the -> distribution, which is not the same as none
distribution in Iceberg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
