sunxiaojian commented on code in PR #6303:
URL: https://github.com/apache/gravitino/pull/6303#discussion_r1922631809
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/paimon/PaimonPropertiesConverter.java:
##########
@@ -37,44 +34,38 @@ private PaimonPropertiesConverter() {}
@Override
public Map<String, String> toGravitinoCatalogProperties(Configuration
flinkConf) {
Review Comment:
fixed
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/PropertiesConverter.java:
##########
@@ -48,7 +61,24 @@ default Map<String, String>
toGravitinoCatalogProperties(Configuration flinkConf
* @return properties for the Flink connector.
*/
default Map<String, String> toFlinkCatalogProperties(Map<String, String>
gravitinoProperties) {
- return gravitinoProperties;
+ Map<String, String> all = Maps.newHashMap();
+ gravitinoProperties.forEach(
+ (key, value) -> {
+ String flinkConfigKey = key;
+ if (key.startsWith(PropertiesConverter.FLINK_PROPERTY_PREFIX)) {
+ flinkConfigKey =
key.substring(PropertiesConverter.FLINK_PROPERTY_PREFIX.length());
+ }
+ all.put(flinkConfigKey, value);
+ });
+ Map<String, String> allProperties = transformPropertiesToFlinkCatalog(all);
+ allProperties.put(CommonCatalogOptions.CATALOG_TYPE.key(),
getFlinkCatalogType());
+ return allProperties;
+ }
+
+ String transformPropertiesToGravitinoCatalog(String configKey);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
