This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch ISSUE-6353
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/ISSUE-6353 by this push:
     new 292b8e57f3 remove validate
292b8e57f3 is described below

commit 292b8e57f37bf6edddba3e12d9a8f0f1bf259804
Author: Rory <[email protected]>
AuthorDate: Thu Jan 23 10:10:44 2025 +0800

    remove validate
---
 .../authorization/chain/ChainedAuthorizationPlugin.java | 10 ----------
 .../authorization/common/AuthorizationProperties.java   | 17 -----------------
 2 files changed, 27 deletions(-)

diff --git 
a/authorizations/authorization-chain/src/main/java/org/apache/gravitino/authorization/chain/ChainedAuthorizationPlugin.java
 
b/authorizations/authorization-chain/src/main/java/org/apache/gravitino/authorization/chain/ChainedAuthorizationPlugin.java
index 120c355db0..e96e560acd 100644
--- 
a/authorizations/authorization-chain/src/main/java/org/apache/gravitino/authorization/chain/ChainedAuthorizationPlugin.java
+++ 
b/authorizations/authorization-chain/src/main/java/org/apache/gravitino/authorization/chain/ChainedAuthorizationPlugin.java
@@ -55,16 +55,6 @@ public class ChainedAuthorizationPlugin implements 
AuthorizationPlugin {
     ChainedAuthorizationProperties chainedAuthzProperties =
         new ChainedAuthorizationProperties(properties);
     chainedAuthzProperties.validate();
-    // Validate the properties for each plugin
-    chainedAuthzProperties
-        .plugins()
-        .forEach(
-            pluginName -> {
-              Map<String, String> pluginProperties =
-                  chainedAuthzProperties.fetchAuthPluginProperties(pluginName);
-              String authzProvider = 
chainedAuthzProperties.getPluginProvider(pluginName);
-              AuthorizationProperties.validate(authzProvider, 
pluginProperties);
-            });
     // Create the plugins
     chainedAuthzProperties
         .plugins()
diff --git 
a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/AuthorizationProperties.java
 
b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/AuthorizationProperties.java
index 3ece6353d6..85fe5c72ed 100644
--- 
a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/AuthorizationProperties.java
+++ 
b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/AuthorizationProperties.java
@@ -34,21 +34,4 @@ public abstract class AuthorizationProperties {
   public abstract String getPropertiesPrefix();
 
   public abstract void validate();
-
-  public static void validate(String type, Map<String, String> properties) {
-    switch (type) {
-      case "ranger":
-        RangerAuthorizationProperties rangerAuthorizationProperties =
-            new RangerAuthorizationProperties(properties);
-        rangerAuthorizationProperties.validate();
-        break;
-      case "chain":
-        ChainedAuthorizationProperties chainedAuthzProperties =
-            new ChainedAuthorizationProperties(properties);
-        chainedAuthzProperties.validate();
-        break;
-      default:
-        throw new IllegalArgumentException("Unsupported authorization 
properties type: " + type);
-    }
-  }
 }

Reply via email to