FANNG1 commented on code in PR #6303:
URL: https://github.com/apache/gravitino/pull/6303#discussion_r1926286527
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/iceberg/TestIcebergPropertiesConverter.java:
##########
@@ -50,7 +52,11 @@ void testCatalogPropertiesWithHiveBackend() {
IcebergPropertiesConstants.ICEBERG_CATALOG_URI,
"hive-uri",
IcebergPropertiesConstants.ICEBERG_CATALOG_WAREHOUSE,
- "hive-warehouse"),
+ "hive-warehouse",
Review Comment:
@sunxiaojian , how about following the logics here?
When creating a catalog, the properties managed by Gravitino are
transformed, the properties starting with `flink.bypass` are left, and the
other properties will add the `flink.bypass` prefix.
When loading a catalog, the properties managed by Gravitino are
transformed, the properties starting with `flink.bypass` are removed from the
prefix, and others are dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
