This is an automated email from the ASF dual-hosted git repository. roryqi pushed a commit to branch ISSUE-6353 in repository https://gitbox.apache.org/repos/asf/gravitino.git
commit 7ba42f6a569610e90967a0d03d1e234a9f99cdab Author: Lord of Abyss <[email protected]> AuthorDate: Mon Jan 20 11:59:31 2025 +0800 [#6235] fix(authz): fix PathBasedMetadataObject toString method (#6252) ### What changes were proposed in this pull request? fix `PathBasedMetadataObject#toString` method. ### Why are the changes needed? Fix: #6235 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? local ut test. --------- Co-authored-by: yangyang zhong <[email protected]> Co-authored-by: Xiaojian Sun <[email protected]> Co-authored-by: roryqi <[email protected]> Co-authored-by: TengYao Chi <[email protected]> Co-authored-by: Qi Yu <[email protected]> Co-authored-by: Chun-Hao Liu <[email protected]> --- .../common/PathBasedMetadataObject.java | 11 ++++++--- .../common/TestPathBasedMetadataObject.java | 27 ++++++++++++++++++++++ 2 files changed, 35 insertions(+), 3 deletions(-) diff --git a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java index 9720b813fa..a1963f6453 100644 --- a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java +++ b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java @@ -122,8 +122,13 @@ public class PathBasedMetadataObject implements AuthorizationMetadataObject { @Override public String toString() { - return "MetadataObject: [fullName=" + fullName() + "], [path=" + path == null - ? "null" - : path + "], [type=" + type + "]"; + String strPath = path == null ? "null" : path; + return "MetadataObject: [fullName=" + + fullName() + + "], [path=" + + strPath + + "], [type=" + + type + + "]"; } } diff --git a/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java b/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java index 3f604b5f38..d2a2291a35 100644 --- a/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java +++ b/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java @@ -47,4 +47,31 @@ public class TestPathBasedMetadataObject { Assertions.assertNotEquals(pathBasedMetadataObject1, pathBasedMetadataObject2); } + + @Test + void testToString() { + PathBasedMetadataObject pathBasedMetadataObject1 = + new PathBasedMetadataObject("parent", "name", "path", PathBasedMetadataObject.Type.PATH); + Assertions.assertEquals( + "MetadataObject: [fullName=parent.name], [path=path], [type=PATH]", + pathBasedMetadataObject1.toString()); + + PathBasedMetadataObject pathBasedMetadataObject2 = + new PathBasedMetadataObject("parent", "name", null, PathBasedMetadataObject.Type.PATH); + Assertions.assertEquals( + "MetadataObject: [fullName=parent.name], [path=null], [type=PATH]", + pathBasedMetadataObject2.toString()); + + PathBasedMetadataObject pathBasedMetadataObject3 = + new PathBasedMetadataObject(null, "name", null, PathBasedMetadataObject.Type.PATH); + Assertions.assertEquals( + "MetadataObject: [fullName=name], [path=null], [type=PATH]", + pathBasedMetadataObject3.toString()); + + PathBasedMetadataObject pathBasedMetadataObject4 = + new PathBasedMetadataObject(null, "name", "path", PathBasedMetadataObject.Type.PATH); + Assertions.assertEquals( + "MetadataObject: [fullName=name], [path=path], [type=PATH]", + pathBasedMetadataObject4.toString()); + } }
