jerryshao commented on code in PR #6367:
URL: https://github.com/apache/gravitino/pull/6367#discussion_r1929703506
##########
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java:
##########
@@ -459,9 +460,16 @@ public static List<String> getMetadataObjectLocation(
// The Hive default schema location is Hive warehouse directory
String defaultSchemaLocation =
getHiveDefaultLocation(ident.namespace().level(0),
ident.name());
- if (defaultSchemaLocation != null &&
!defaultSchemaLocation.isEmpty()) {
+ if (StringUtils.isNotBlank(defaultSchemaLocation)) {
locations.add(defaultSchemaLocation);
}
+ } else if (catalogObj.provider().equals("hadoop")) {
+ String catalogLocation =
catalogObj.properties().get(HiveConstants.LOCATION);
Review Comment:
I'm a little surprised that our `core` module relies on `catalog-common`
module, which is not what I want, `catalog-common` as its name, should always
be used by catalog-* modules and other modules rely on catalog. But for `core`
module, the dependency relation is the opposite, we should fix this.
I saw it is introduced by @FANNG1 , so we really should fix it.
Besides, why a hadoop catalog needs to get a Hive property definition? It's
weird to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
