tengqm commented on code in PR #6483:
URL: https://github.com/apache/gravitino/pull/6483#discussion_r1962573370
##########
clients/cli/src/main/java/org/apache/gravitino/cli/CommandContext.java:
##########
@@ -55,6 +56,8 @@ public CommandContext(CommandLine line) {
? line.getOptionValue(GravitinoOptions.OUTPUT)
: Command.OUTPUT_FORMAT_PLAIN;
this.quiet = line.hasOption(GravitinoOptions.QUIET);
+ // TODO add limit option to CLI
+ this.outputLimit = -1;
Review Comment:
Pleas rethink this design...
If we have received a long list to show in the table, and the purpose of
this option is to show only part of it, that would be a bad design.
A more common pattern for LIST is to provide `start` and `limit` as a pair.
These two options can be used to control how many items you want to retrieve
from the server, not how many items you want to show in a tabular format. These
two options can also be used to support paging, i.e. retrieve things in trunks.
My previous feedback wasn't that `limit` is useless. It is specific to LIST
operations. You won't use it when you CREATE/UPDATE/DELETE/PATCH something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
