tengqm commented on code in PR #6501:
URL: https://github.com/apache/gravitino/pull/6501#discussion_r1967591142
##########
docs/gravitino-server-config.md:
##########
@@ -37,6 +37,7 @@ The `gravitino.conf` file lists the configuration items in
the following table.
| `gravitino.server.shutdown.timeout` | Time in milliseconds
to gracefully shut down of the Gravitino webserver.
| `3000`
| No | 0.2.0 |
| `gravitino.server.webserver.customFilters` | Comma-separated list
of filter class names to apply to the API.
| (none)
| No | 0.4.0 |
| `gravitino.server.rest.extensionPackages` | Comma-separated list
of REST API packages to expand
| (none)
| No | 0.6.0-incubating |
+| `gravitino.server.visibleConfigs` | List of configs that
are visible in the config servlet
| (none)
| No | 0.9.0-incubating |
Review Comment:
:) This is a pretty honest name. It can be parsed as "... I have many
configs, but I can only show you some ...".
##########
server/src/test/java/org/apache/gravitino/server/web/TestConfigServlet.java:
##########
@@ -43,4 +45,23 @@ public void testConfigServlet() throws Exception {
"{\"gravitino.authorization.enable\":false,\"gravitino.authenticators\":[\"simple\"]}");
configServlet.destroy();
}
+
+ @Test
+ public void testConfigServletWithVisibleConfigs() throws Exception {
+ ServerConfig serverConfig = new ServerConfig();
+ serverConfig.set(
+ Configs.VISIBLE_CONFIGS,
+ Lists.newArrayList(Configs.AUDIT_LOG_FORMATTER_CLASS_NAME.getKey()));
+ serverConfig.set(Configs.AUDIT_LOG_FORMATTER_CLASS_NAME, "test");
Review Comment:
Em ... this is an interesting test case. Can we use something more
realistic? I'm not sure who wants to know the audit log formatter class? Maybe
there are something I missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
