Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

Tue, 25 Feb 2025 00:28:35 -0800 


Abyss-lord commented on code in PR #6497:
URL: https://github.com/apache/gravitino/pull/6497#discussion_r1969248527


##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java:
##########
@@ -124,14 +137,98 @@ public CatalogListPlainFormat(CommandContext context) {
     /** {@inheritDoc} */
     @Override
     public String getOutput(Catalog[] catalogs) {
-      if (catalogs == null || catalogs.length == 0) {
-        output("No catalogs exist.", System.out);
-        return null;
-      } else {
-        List<String> catalogNames =
-            
Arrays.stream(catalogs).map(Catalog::name).collect(Collectors.toList());
-        return NEWLINE_JOINER.join(catalogNames);
-      }
+
+      List<String> catalogNames =
+          
Arrays.stream(catalogs).map(Catalog::name).collect(Collectors.toList());
+      return NEWLINE_JOINER.join(catalogNames);
+    }
+  }

Review Comment:
   
![image](https://github.com/user-attachments/assets/d218087f-2ef0-418a-b4e2-a4ae47ffa489)
   @justinmclean  It will be handled at the Command level
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to