yuqi1129 opened a new issue, #6566:
URL: https://github.com/apache/gravitino/issues/6566
### What would you like to be improved?
`catalogInUse` and `metalakeInUse` is called frequently and very
time-consuming as it directly load data from backend storage, which can be
optimized.
```
protected <R, E extends Throwable> R doWithCatalog(
NameIdentifier ident, ThrowableFunction<CatalogManager.CatalogWrapper,
R> fn, Class<E> ex)
throws E {
checkCatalogInUse(store, ident);
try {
CatalogManager.CatalogWrapper c =
catalogManager.loadCatalogAndWrap(ident);
return fn.apply(c);
} catch (Throwable throwable) {
if (ex.isInstance(throwable)) {
throw ex.cast(throwable);
}
if (RuntimeException.class.isAssignableFrom(throwable.getClass())) {
throw (RuntimeException) throwable;
}
throw new RuntimeException(throwable);
}
}
public static void checkCatalogInUse(EntityStore store, NameIdentifier
ident)
throws NoSuchMetalakeException, NoSuchCatalogException,
CatalogNotInUseException,
MetalakeNotInUseException {
NameIdentifier metalakeIdent =
NameIdentifier.of(ident.namespace().levels());
checkMetalake(metalakeIdent, store);
if (!getCatalogInUseValue(store, ident)) {
throw new CatalogNotInUseException("Catalog %s is not in use, please
enable it first", ident);
}
}
private static boolean getCatalogInUseValue(EntityStore store,
NameIdentifier catalogIdent) {
try {
CatalogEntity catalogEntity =
store.get(catalogIdent, EntityType.CATALOG, CatalogEntity.class);
return (boolean)
BASIC_CATALOG_PROPERTIES_METADATA.getOrDefault(
catalogEntity.getProperties(), PROPERTY_IN_USE);
} catch (NoSuchEntityException e) {
LOG.warn("Catalog {} does not exist", catalogIdent, e);
throw new NoSuchCatalogException(CATALOG_DOES_NOT_EXIST_MSG,
catalogIdent);
} catch (IOException e) {
LOG.error("Failed to do store operation", e);
throw new RuntimeException(e);
}
}
public static boolean metalakeInUse(EntityStore store, NameIdentifier
ident)
throws NoSuchMetalakeException {
try {
BaseMetalake metalake = store.get(ident, EntityType.METALAKE,
BaseMetalake.class);
return (boolean)
metalake.propertiesMetadata().getOrDefault(metalake.properties(),
PROPERTY_IN_USE);
} catch (NoSuchEntityException e) {
LOG.warn("Metalake {} does not exist", ident, e);
throw new NoSuchMetalakeException(METALAKE_DOES_NOT_EXIST_MSG, ident);
} catch (IOException e) {
LOG.error("Failed to do store operation", e);
throw new RuntimeException(e);
}
}
```
### How should we improve?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
