xunliu commented on code in PR #6515:
URL: https://github.com/apache/gravitino/pull/6515#discussion_r1974888545
##########
authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveIT.java:
##########
@@ -266,6 +269,9 @@ public void testOnRoleDeleted() {
Assertions.assertTrue(rangerAuthHivePlugin.onRoleDeleted(role));
// Check if the policy is deleted
assertFindManagedPolicyItems(role, false);
+
+ // Repeat to delete the same role to verify the idempotent operation
+ Assertions.assertTrue(rangerAuthHivePlugin.onRoleDeleted(role));
Review Comment:
Why is it judging true or false here?
Please add, separately, the test cases you added that throw the 4 exceptions.
##########
authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveIT.java:
##########
@@ -138,6 +138,9 @@ public void testOnRoleCreated() {
RoleEntity role = mock3TableRole(currentFunName());
Assertions.assertTrue(rangerAuthHivePlugin.onRoleCreated(role));
verifyRoleInRanger(rangerAuthHivePlugin, role);
+
+ // Repeat to create the same to verify the idempotent operation
+ Assertions.assertTrue(rangerAuthHivePlugin.onRoleCreated(role));
Review Comment:
Why is it judging true or false here?
Please add, separately, the test cases you added that throw the 4 exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
