jerqi commented on code in PR #6575:
URL: https://github.com/apache/gravitino/pull/6575#discussion_r1977418641


##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java:
##########
@@ -679,4 +680,57 @@ public Boolean onMetadataUpdated(MetadataObjectChange... 
changes) throws Runtime
     }
     return Boolean.TRUE;
   }
+
+  @Override
+  protected String getServiceType() {
+    return "hdfs";
+  }
+
+  @Override
+  protected Map<String, String> getServiceConfigs(Map<String, String> config) {
+    String usernameKey = "username";
+    String usernameVal = "admin";
+    if (config.containsKey(BaseCatalog.CATALOG_BYPASS_PREFIX + usernameKey)) {
+      usernameVal = config.get(BaseCatalog.CATALOG_BYPASS_PREFIX + 
usernameKey);
+    }
+
+    String passwordKey = "password";
+    String passwordVal = "admin";

Review Comment:
   We could pass fake value. I can add comment to avoid others worrying about 
the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to