yuqi1129 commented on PR #6581:
URL: https://github.com/apache/gravitino/pull/6581#issuecomment-2696057844

   > Thanks! but unfortunately, I think we don't need this, as `Catalog.Type` 
is already clear enough.
   
   This sounds reasonable. Java API is as follows 
   
   ```
     public Catalog createCatalog(
         String catalogName,
         Catalog.Type type,
         String provider,
         String comment,
         Map<String, String> properties)
         throws NoSuchMetalakeException, CatalogAlreadyExistsException {
       return getMetalake().createCatalog(catalogName, type, provider, comment, 
properties);
     }
   ```
   
   Could you try to change python API and change the parameter name from 
`catalog_type` to `type` to make it consistent with JAVA API. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to