tengqm commented on code in PR #6677:
URL: https://github.com/apache/gravitino/pull/6677#discussion_r1992460182
##########
build.gradle.kts:
##########
@@ -82,28 +82,26 @@ project.extra["extraJvmArgs"] = if (extra["jdkVersion"] in
listOf("8", "11")) {
listOf(
"-XX:+IgnoreUnrecognizedVMOptions",
"--add-opens", "java.base/java.io=ALL-UNNAMED",
+ "--add-opens", "java.base/java.lang=ALL-UNNAMED",
"--add-opens", "java.base/java.lang.invoke=ALL-UNNAMED",
"--add-opens", "java.base/java.lang.reflect=ALL-UNNAMED",
- "--add-opens", "java.base/java.lang=ALL-UNNAMED",
"--add-opens", "java.base/java.math=ALL-UNNAMED",
"--add-opens", "java.base/java.net=ALL-UNNAMED",
"--add-opens", "java.base/java.nio=ALL-UNNAMED",
"--add-opens", "java.base/java.text=ALL-UNNAMED",
"--add-opens", "java.base/java.time=ALL-UNNAMED",
"--add-opens", "java.base/java.util.concurrent.atomic=ALL-UNNAMED",
"--add-opens", "java.base/java.util.concurrent=ALL-UNNAMED",
- "--add-opens", "java.base/java.util.regex=ALL-UNNAMED",
"--add-opens", "java.base/java.util=ALL-UNNAMED",
+ "--add-opens", "java.base/java.util.regex=ALL-UNNAMED",
"--add-opens", "java.base/jdk.internal.ref=ALL-UNNAMED",
"--add-opens", "java.base/jdk.internal.reflect=ALL-UNNAMED",
"--add-opens", "java.sql/java.sql=ALL-UNNAMED",
- "--add-opens", "java.base/sun.util.calendar=ALL-UNNAMED",
"--add-opens", "java.base/sun.nio.ch=ALL-UNNAMED",
"--add-opens", "java.base/sun.nio.cs=ALL-UNNAMED",
"--add-opens", "java.base/sun.security.action=ALL-UNNAMED",
"--add-opens", "java.base/sun.util.calendar=ALL-UNNAMED",
"--add-opens", "java.security.jgss/sun.security.krb5=ALL-UNNAMED",
- "--add-opens", "java.base/java.lang.reflect=ALL-UNNAMED"
Review Comment:
To reviwers: This entry was found to be duplicated after sorting the list.
##########
build.gradle.kts:
##########
@@ -783,13 +797,20 @@ tasks {
register("copySubprojectDependencies", Copy::class) {
subprojects.forEach() {
- if (!it.name.startsWith("catalog") &&
- !it.name.startsWith("authorization") &&
+ if (!it.name.startsWith("authorization") &&
+ !it.name.startsWith("catalog") &&
!it.name.startsWith("cli") &&
- !it.name.startsWith("client") && !it.name.startsWith("filesystem") &&
!it.name.startsWith("spark") && !it.name.startsWith("iceberg") && it.name !=
"trino-connector" &&
- it.name != "integration-test" && it.name != "bundled-catalog" &&
!it.name.startsWith("flink") &&
- it.name != "integration-test" && it.name != "hive-metastore-common" &&
!it.name.startsWith("flink") &&
- it.parent?.name != "bundles" && it.name != "hadoop-common"
+ !it.name.startsWith("client") &&
+ !it.name.startsWith("filesystem") &&
+ !it.name.startsWith("flink") &&
Review Comment:
To reviwers: by wrapping the long line, we found that 'flink' is duplicated.
##########
build.gradle.kts:
##########
@@ -82,28 +82,26 @@ project.extra["extraJvmArgs"] = if (extra["jdkVersion"] in
listOf("8", "11")) {
listOf(
"-XX:+IgnoreUnrecognizedVMOptions",
"--add-opens", "java.base/java.io=ALL-UNNAMED",
+ "--add-opens", "java.base/java.lang=ALL-UNNAMED",
"--add-opens", "java.base/java.lang.invoke=ALL-UNNAMED",
"--add-opens", "java.base/java.lang.reflect=ALL-UNNAMED",
- "--add-opens", "java.base/java.lang=ALL-UNNAMED",
"--add-opens", "java.base/java.math=ALL-UNNAMED",
"--add-opens", "java.base/java.net=ALL-UNNAMED",
"--add-opens", "java.base/java.nio=ALL-UNNAMED",
"--add-opens", "java.base/java.text=ALL-UNNAMED",
"--add-opens", "java.base/java.time=ALL-UNNAMED",
"--add-opens", "java.base/java.util.concurrent.atomic=ALL-UNNAMED",
"--add-opens", "java.base/java.util.concurrent=ALL-UNNAMED",
- "--add-opens", "java.base/java.util.regex=ALL-UNNAMED",
"--add-opens", "java.base/java.util=ALL-UNNAMED",
+ "--add-opens", "java.base/java.util.regex=ALL-UNNAMED",
"--add-opens", "java.base/jdk.internal.ref=ALL-UNNAMED",
"--add-opens", "java.base/jdk.internal.reflect=ALL-UNNAMED",
"--add-opens", "java.sql/java.sql=ALL-UNNAMED",
- "--add-opens", "java.base/sun.util.calendar=ALL-UNNAMED",
Review Comment:
To reviwers: This entry was found to be duplicated after sorting the list.
##########
build.gradle.kts:
##########
@@ -823,16 +846,16 @@ tasks {
register("copyCatalogLibAndConfigs", Copy::class) {
dependsOn(
+ ":catalogs:catalog-hadoop:copyLibAndConfig",
":catalogs:catalog-hive:copyLibAndConfig",
- ":catalogs:catalog-lakehouse-iceberg:copyLibAndConfig",
- ":catalogs:catalog-lakehouse-paimon:copyLibAndConfig",
- "catalogs:catalog-lakehouse-hudi:copyLibAndConfig",
":catalogs:catalog-jdbc-doris:copyLibAndConfig",
":catalogs:catalog-jdbc-mysql:copyLibAndConfig",
":catalogs:catalog-jdbc-oceanbase:copyLibAndConfig",
":catalogs:catalog-jdbc-postgresql:copyLibAndConfig",
- ":catalogs:catalog-hadoop:copyLibAndConfig",
":catalogs:catalog-kafka:copyLibAndConfig",
+ ":catalogs:catalog-lakehouse-hudi:copyLibAndConfig",
Review Comment:
To reviewers: 'catalogs:catalog-lakehouse-hudi:copyLibAndConfig' was missing
the leading ':'.
##########
build.gradle.kts:
##########
@@ -523,44 +526,44 @@ tasks.rat {
val exclusions = mutableListOf(
// Ignore files we track but do not need full headers
"**/.github/**/*",
- "dev/docker/**/*.xml",
- "dev/docker/**/*.conf",
- "dev/docker/kerberos-hive/kadm5.acl",
"**/*.log",
"**/*.out",
- "**/trino-ci-testset",
"**/licenses/*.txt",
"**/licenses/*.md",
- "docs/**/*.md",
- "spark-connector/spark-common/src/test/resources/**",
- "web/web/.**",
- "web/web/next-env.d.ts",
- "web/web/dist/**/*",
- "web/web/node_modules/**/*",
- "web/web/src/lib/utils/axios/**/*",
- "web/web/src/lib/enums/httpEnum.js",
- "web/web/src/types/axios.d.ts",
- "web/web/yarn.lock",
- "web/web/package-lock.json",
- "web/web/pnpm-lock.yaml",
- "web/web/src/lib/icons/svg/**/*.svg",
"**/LICENSE.*",
"**/NOTICE.*",
- "DISCLAIMER_WIP.txt",
+ "**/trino-ci-testset",
"DISCLAIMER.txt",
+ "DISCLAIMER_WIP.txt",
"ROADMAP.md",
+ "clients/cli/src/main/resources/*.txt",
"clients/client-python/.pytest_cache/*",
- "clients/client-python/**/__pycache__",
"clients/client-python/.venv/*",
+ "clients/client-python/**/__pycache__",
"clients/client-python/venv/*",
"clients/client-python/apache_gravitino.egg-info/*",
+ "clients/client-python/docs/build",
+ "clients/client-python/docs/source/generated",
"clients/client-python/gravitino/utils/http_client.py",
"clients/client-python/tests/unittests/htmlcov/*",
"clients/client-python/tests/integration/htmlcov/*",
- "clients/client-python/docs/build",
- "clients/client-python/docs/source/generated",
- "clients/cli/src/main/resources/*.txt",
- "clients/filesystem-fuse/Cargo.lock"
+ "clients/filesystem-fuse/Cargo.lock",
+ "dev/docker/**/*.xml",
+ "dev/docker/**/*.conf",
+ "dev/docker/kerberos-hive/kadm5.acl",
+ "docs/**/*.md",
+ "spark-connector/spark-common/src/test/resources/**",
+ "web/web/.**",
+ "web/web/dist/**/*",
+ "web/web/next-env.d.ts",
+ "web/web/node_modules/**/*",
+ "web/web/package-lock.json",
+ "web/web/pnpm-lock.yaml",
+ "web/web/src/lib/enums/httpEnum.js",
+ "web/web/src/lib/icons/svg/**/*.svg",
+ "web/web/src/lib/utils/axios/**/*",
+ "web/web/src/types/axios.d.ts",
+ "web/web/yarn.lock"
Review Comment:
To reviwers: contents not changed other than sorting the entries
##########
build.gradle.kts:
##########
@@ -593,7 +596,14 @@ tasks {
val outputDir = projectDir.dir("distribution")
val compileDistribution by registering {
- dependsOn(":web:web:build", "copySubprojectDependencies",
"copyCatalogLibAndConfigs", ":authorizations:copyLibAndConfig",
"copySubprojectLib", "iceberg:iceberg-rest-server:copyLibAndConfigs")
+ dependsOn(
+ "copyCatalogLibAndConfigs",
+ "copySubprojectDependencies",
+ "copySubprojectLib",
+ ":authorizations:copyLibAndConfig",
+ ":iceberg:iceberg-rest-server:copyLibAndConfigs",
Review Comment:
To reviwers: by wrapping the long line, the missing leading ':' for iceberg
one becomes obvious.
##########
build.gradle.kts:
##########
@@ -783,13 +797,20 @@ tasks {
register("copySubprojectDependencies", Copy::class) {
subprojects.forEach() {
- if (!it.name.startsWith("catalog") &&
- !it.name.startsWith("authorization") &&
+ if (!it.name.startsWith("authorization") &&
+ !it.name.startsWith("catalog") &&
!it.name.startsWith("cli") &&
- !it.name.startsWith("client") && !it.name.startsWith("filesystem") &&
!it.name.startsWith("spark") && !it.name.startsWith("iceberg") && it.name !=
"trino-connector" &&
- it.name != "integration-test" && it.name != "bundled-catalog" &&
!it.name.startsWith("flink") &&
- it.name != "integration-test" && it.name != "hive-metastore-common" &&
!it.name.startsWith("flink") &&
- it.parent?.name != "bundles" && it.name != "hadoop-common"
+ !it.name.startsWith("client") &&
+ !it.name.startsWith("filesystem") &&
+ !it.name.startsWith("flink") &&
+ !it.name.startsWith("iceberg") &&
+ !it.name.startsWith("spark") &&
+ it.name != "bundled-catalog" &&
+ it.name != "hadoop-common" &&
+ it.name != "hive-metastore-common" &&
+ it.name != "integration-test" &&
Review Comment:
To reviwers: by wrapping the long line and sorting the entries, duplication
of 'integration-test' is obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
