tengqm commented on code in PR #6686: URL: https://github.com/apache/gravitino/pull/6686#discussion_r1992919990
########## bin/gcli.sh.template: ########## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# Referred from Apache Submarine's common.sh implementation +# bin/common.sh + +set -e + +if [ -L "${BASH_SOURCE-$0}" ]; then + FWDIR=$(dirname "$(readlink "${BASH_SOURCE-$0}")") Review Comment: what does 'FWDIR' means? ########## clients/cli/README.md: ########## @@ -52,7 +52,7 @@ Before you can build and run this project, it is suggested you have the followin 3. Create an alias: ```bash - alias gcli='java -jar clients/cli/build/libs/gravitino-cli-*-incubating-SNAPSHOT.jar' + alias gcli='sh $GRAVITINO_HOME/bin/gcli.sh' Review Comment: Can we solve this problem by having `java` search for the right jar rather than introducing another layer of indirection? Personally I don't like this approach, especially considering that the `gcli` alias is starting a new shell. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
