tengqm commented on code in PR #6686:
URL: https://github.com/apache/gravitino/pull/6686#discussion_r2000622393
##########
clients/cli/README.md:
##########
@@ -52,7 +52,7 @@ Before you can build and run this project, it is suggested
you have the followin
3. Create an alias:
```bash
- alias gcli='java -jar
clients/cli/build/libs/gravitino-cli-*-incubating-SNAPSHOT.jar'
+ alias gcli='sh $GRAVITINO_HOME/bin/gcli.sh'
Review Comment:
My first suggestion is that we may want to wrap our `java` invocation
directly in our shell scripts. When we have one script wrapping a `java`
process, we do our jobs in that script, e.g. checking and preparing the
environment.
The gcli -> sh -> gcli.sh -> java invocation chain doesn't make a lot senses
to me. I don't think the existing alias needs another layer of indirection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
