yuqi1129 commented on code in PR #6698:
URL: https://github.com/apache/gravitino/pull/6698#discussion_r2006699862
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java:
##########
@@ -724,4 +721,14 @@ protected Map<String, String>
getServiceConfigs(Map<String, String> config) {
RangerAuthorizationProperties.FS_DEFAULT_VALUE))
.build();
}
+
+ private static AuthorizationMetadataObject.Type getType(MetadataObject
metadataObject) {
+
Review Comment:
This empty line seems to be excessive.
##########
authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java:
##########
@@ -27,11 +29,23 @@
public class PathBasedMetadataObject implements AuthorizationMetadataObject {
/**
* The type of metadata object in the underlying system. Every type will map
one kind of the
- * entity of the Gravitino type system.
+ * entity of the Gravitino type system. When we store a Hive table, first,
we will store the
+ * metadata in the MySQL, and then we will store the data in the HDFS
location. For Hive, there is
Review Comment:
...in the MySQL... ， better change it to JDBC database like MySQL
##########
authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java:
##########
@@ -27,11 +29,23 @@
public class PathBasedMetadataObject implements AuthorizationMetadataObject {
/**
* The type of metadata object in the underlying system. Every type will map
one kind of the
- * entity of the Gravitino type system.
+ * entity of the Gravitino type system. When we store a Hive table, first,
we will store the
+ * metadata in the MySQL, and then we will store the data in the HDFS
location. For Hive, there is
+ * a default location for the cluster level. We can also specify other
locations for schema and
+ * table levels. So a path may not be fileset
*/
public enum Type implements AuthorizationMetadataObject.Type {
/** A path is mapped the path of storages like HDFS, S3 etc. */
- PATH(MetadataObject.Type.FILESET);
+ FILESET_PATH(MetadataObject.Type.FILESET),
+ /** A path is mapped the path of table storage like Hive. */
+ TABLE_PATH(MetadataObject.Type.TABLE),
+ /** A path is mapped the path of schema storage like Hive. */
Review Comment:
Can you try to improve the comment here? I can't understand it clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
