This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 6b7cb02de8 [#6638] Optimize method `listColumnPOsByTableIdAndVersion`
to make it more efficient (#6640)
6b7cb02de8 is described below
commit 6b7cb02de8f4bc84528570a5e515a6790388e23c
Author: Mini Yu <[email protected]>
AuthorDate: Fri Mar 21 19:45:28 2025 +0800
[#6638] Optimize method `listColumnPOsByTableIdAndVersion` to make it more
efficient (#6640)
### What changes were proposed in this pull request?
Add filter condition `table_id` in method
`listColumnPOsByTableIdAndVersion`.
### Why are the changes needed?
It's a performance improvement.
Fix: #6638
### Does this PR introduce _any_ user-facing change?
N/A.
### How was this patch tested?
Existing UTs
---
.../relational/mapper/provider/base/TableColumnBaseSQLProvider.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/TableColumnBaseSQLProvider.java
b/core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/TableColumnBaseSQLProvider.java
index d6154c907b..1ed117b8da 100644
---
a/core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/TableColumnBaseSQLProvider.java
+++
b/core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/TableColumnBaseSQLProvider.java
@@ -44,7 +44,8 @@ public class TableColumnBaseSQLProvider {
+ TableColumnMapper.COLUMN_TABLE_NAME
+ " WHERE table_id = #{tableId} AND table_version <= #{tableVersion}
AND deleted_at = 0"
+ " GROUP BY column_id) t2"
- + " ON t1.column_id = t2.column_id AND t1.table_version =
t2.max_table_version";
+ + " ON t1.column_id = t2.column_id AND t1.table_version =
t2.max_table_version"
+ + " AND t1.table_id = #{tableId}";
}
public String insertColumnPOs(@Param("columnPOs") List<ColumnPO> columnPOs) {