jerqi commented on code in PR #6770:
URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018108296
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##########
@@ -735,18 +735,29 @@ public Boolean onUserAdded(User user) throws
AuthorizationPluginException {
@Override
public Boolean onUserRemoved(User user) throws AuthorizationPluginException {
VXUserList list = rangerClient.searchUser(ImmutableMap.of("name",
user.name()));
- if (list.getListSize() == 0) {
- LOG.warn("The user({}) doesn't exist in the Ranger!", user);
+ boolean isExist = false;
+ long userId = 0;
Review Comment:
OK.
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##########
@@ -761,18 +772,36 @@ public Boolean onGroupAdded(Group group) throws
AuthorizationPluginException {
@Override
public Boolean onGroupRemoved(Group group) throws
AuthorizationPluginException {
- VXGroupList list = rangerClient.searchGroup(ImmutableMap.of("name",
group.name()));
- if (list.getListSize() == 0) {
- LOG.warn("The group({}) doesn't exist in the Ranger!", group);
+ VXGroupList vxGroupList = rangerClient.searchGroup(ImmutableMap.of("name",
group.name()));
+ boolean isExist = false;
+ long groupId = -1;
Review Comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
