shaofengshi commented on code in PR #21: URL: https://github.com/apache/gravitino-playground/pull/21#discussion_r2022721561
########## init/gravitino/init.sh: ########## @@ -2,9 +2,16 @@ # Copyright 2023 Datastrato Pvt Ltd. # This software is licensed under the Apache License version 2. # -echo "Start to download the jar package of JDBC" -wget https://repo1.maven.org/maven2/mysql/mysql-connector-java/8.0.27/mysql-connector-java-8.0.27.jar -O /root/gravitino/catalogs/jdbc-mysql/libs/mysql-connector-java-8.0.27.jar -wget https://jdbc.postgresql.org/download/postgresql-42.7.0.jar -O /root/gravitino/catalogs/jdbc-postgresql/libs/postgresql-42.7.0.jar +echo "Downloading the JDBC drivers for MySQL and PostgreSQL" Review Comment: I agree with Royi, that this script won't be executed in local; Instead, it would be executed in the Gravitino docker container as an entrypoint script; And the Gravitino docker contianer is based on a Linux docker image, which already have wget installed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
