unknowntpo commented on code in PR #6848:
URL: https://github.com/apache/gravitino/pull/6848#discussion_r2032464609
##########
dev/docker/ranger/ranger-dependency.sh:
##########
@@ -36,7 +36,36 @@ if [[ ! -d "${ranger_dir}/packages" ]]; then
fi
if [ ! -f "${ranger_dir}/packages/${RANGER_PACKAGE_NAME}" ]; then
- curl -L -s -o "${ranger_dir}/packages/${RANGER_PACKAGE_NAME}"
${RANGER_DOWNLOAD_URL}
+ # Package not exist, we need to build them from source
+ if [ ! -d "${ranger_dir}/packages/apache-ranger" ]; then
+ git clone https://github.com/apache/ranger --branch master
--single-branch ${ranger_dir}/packages/apache-ranger
+ # set the commit to RANGER-5146: 500 API Error When Deleting
TagDef with a Linked Tag
+ #
https://github.com/apache/ranger/commit/ff36aabe36169b94862c51a5b403f59c9d728b94
+ git reset --hard ff36aabe36169b94862c51a5b403f59c9d728b94
+ fi
+
+ cp ${ranger_dir}/.env
${ranger_dir}/packages/apache-ranger/dev-support/ranger-docker
+
+ cd ${ranger_dir}/packages/apache-ranger/dev-support/ranger-docker
+
+ # Prevent builder to pull remote image
+ # https://github.com/moby/buildkit/issues/2343#issuecomment-1311890308
+ docker builder prune -f
+ docker builder use default
Review Comment:
I think these two lines are dealing with the same thing, so I don't add new
line between them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
