FANNG1 commented on code in PR #6866:
URL: https://github.com/apache/gravitino/pull/6866#discussion_r2036897349
##########
core/src/main/java/org/apache/gravitino/listener/api/event/AccessControlEventDispatcher.java:
##########
@@ -346,7 +340,8 @@ public Role createRole(
return roleObject;
} catch (Exception e) {
- // TODO: add failure event
+ eventBus.dispatchEvent(
+ new CreateRoleFailureEvent(initiator, metalake, e, role, properties,
securableObjects));
Review Comment:
How about creating a roleInfo to represent createRoleRequest with role,
properties, securableObjects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
