FANNG1 commented on code in PR #6599: URL: https://github.com/apache/gravitino/pull/6599#discussion_r2041773049
########## dev/charts/gravitino/resources/config/gravitino.conf: ########## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# THE CONFIGURATION FOR Gravitino SERVER +gravitino.server.shutdown.timeout = {{ .Values.server.shutdownTimeout | default 3000 }} + +# THE CONFIGURATION FOR Gravitino WEB SERVER +gravitino.server.webserver.host = {{ .Values.webserver.host | default "0.0.0.0" }} +gravitino.server.webserver.httpPort = {{ .Values.webserver.httpPort | default 8090 }} +gravitino.server.webserver.minThreads = {{ .Values.webserver.minThreads | default 24 }} +gravitino.server.webserver.maxThreads = {{ .Values.webserver.maxThreads | default 200 }} +gravitino.server.webserver.stopTimeout = {{ .Values.webserver.stopTimeout | default 30000 }} +gravitino.server.webserver.idleTimeout = {{ .Values.webserver.idleTimeout | default 30000 }} +gravitino.server.webserver.threadPoolWorkQueueSize = {{ .Values.webserver.threadPoolWorkQueueSize | default 100 }} +gravitino.server.webserver.requestHeaderSize = {{ .Values.webserver.requestHeaderSize | default 131072 }} +gravitino.server.webserver.responseHeaderSize = {{ .Values.webserver.responseHeaderSize | default 131072 }} + +# Comma-separated list of filter class names to apply to the API. +gravitino.server.webserver.customFilters = {{ .Values.webserver.customFilters }} + +# Comma-separated list of REST API packages to expand +gravitino.server.rest.extensionPackages = {{ .Values.server.rest.extensionPackages }} + +# THE CONFIGURATION FOR Gravitino ENTITY STORE +gravitino.entity.store = {{ .Values.entity.store | default "relational" }} +gravitino.entity.store.maxTransactionSkewTimeMs = {{ .Values.entity.maxTransactionSkewTimeMs }} +gravitino.entity.store.deleteAfterTimeMs = {{ (.Values.entity.deleteAfterTimeMs | default 604800000) | int }} +gravitino.entity.store.versionRetentionCount = {{ .Values.entity.versionRetentionCount }} +gravitino.entity.store.relational = {{ .Values.entity.relationalBackend | default "JDBCBackend" }} +gravitino.entity.store.relational.jdbcUrl = {{ if .Values.mysql.enabled }}jdbc:mysql://{{ .Release.Name }}-mysql:3306/{{ .Values.mysql.auth.database }}{{ else }}{{ .Values.entity.jdbcUrl }}{{ end }} +gravitino.entity.store.relational.jdbcDriver = {{ if .Values.mysql.enabled }}com.mysql.cj.jdbc.Driver{{ else }}{{ .Values.entity.jdbcDriver }}{{ end }} +gravitino.entity.store.relational.jdbcUser = {{ if .Values.mysql.enabled }}{{ .Values.mysql.auth.username }}{{ else }}{{ .Values.entity.jdbcUser }}{{ end }} +gravitino.entity.store.relational.jdbcPassword = {{ if .Values.mysql.enabled }}{{ .Values.mysql.auth.password }}{{ else }}{{ .Values.entity.jdbcPassword }}{{ end }} +gravitino.entity.store.relational.storagePath = {{ .Values.entity.storagePath }} + +# THE CONFIGURATION FOR Gravitino CATALOG +gravitino.catalog.cache.evictionIntervalMs = {{ if .Values.catalog.evictionIntervalMs }}{{ .Values.catalog.evictionIntervalMs }}{{ else }}3600000{{ end }} +gravitino.catalog.classloader.isolated = {{ .Values.catalog.classloader.isolated }} + +# THE CONFIGURATION FOR authorization +gravitino.authorization.enable = {{ .Values.authorization.enable }} +gravitino.authorization.serviceAdmins = {{ .Values.authorization.serviceAdmins }} +gravitino.authenticators = {{ .Values.authenticators }} +gravitino.authenticator.oauth.serviceAudience = {{ .Values.authenticator.oauth.serviceAudience }} +gravitino.authenticator.oauth.defaultSignKey = {{ .Values.authenticator.oauth.defaultSignKey }} +gravitino.authenticator.oauth.serverUri = {{ .Values.authenticator.oauth.serverUri }} +gravitino.authenticator.oauth.tokenPath = {{ .Values.authenticator.oauth.tokenPath }} + +# THE CONFIGURATION FOR AUXILIARY SERVICE +gravitino.auxService.names = {{ .Values.auxService.names | default "iceberg-rest" }} +gravitino.iceberg-rest.classpath = {{ .Values.icebergRest.classpath | default "iceberg-rest-server/libs, iceberg-rest-server/conf" }} +gravitino.iceberg-rest.host = {{ .Values.icebergRest.host | default "0.0.0.0" }} +gravitino.iceberg-rest.httpPort = {{ .Values.icebergRest.httpPort | default 9001 }} +gravitino.iceberg-rest.catalog-backend = {{ .Values.icebergRest.catalogBackend | default "memory" }} +gravitino.iceberg-rest.warehouse = {{ .Values.icebergRest.warehouse | default "/tmp/" }} + +# Audit log configuration +gravitino.audit.enabled = {{ .Values.audit.enabled }} +gravitino.audit.writer.className = {{ .Values.audit.writer.className }} +gravitino.audit.formatter.className = {{ .Values.audit.formatter.className }} +gravitino.audit.writer.file.fileName = {{ .Values.audit.writer.file.fileName }} +gravitino.audit.writer.file.flushIntervalSecs = {{ .Values.audit.writer.file.flushIntervalSecs }} +gravitino.audit.writer.file.append = {{ .Values.audit.writer.file.append }} Review Comment: I'm ok with the configuration items, the main concern is we should maintenance the default value in two places, one in Gravitino code base, the other in `values.yaml`, this may lead inconsistent, and is it necessary to export `gravitino.audit.writer.className` to user? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
