This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new ae8a9cceb1 [#6875] fix: Update outdated comments for complex types
(#6999)
ae8a9cceb1 is described below
commit ae8a9cceb16159e0d744fb834d637a8d696728a1
Author: RickyMa <[email protected]>
AuthorDate: Fri Apr 18 18:12:09 2025 +0800
[#6875] fix: Update outdated comments for complex types (#6999)
### What changes were proposed in this pull request?
Update outdated comments for complex types.
### Why are the changes needed?
Fix: #6875
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs.
---
.../main/java/org/apache/gravitino/rel/types/Types.java | 17 ++++-------------
clients/client-python/gravitino/api/types/types.py | 10 ++++------
2 files changed, 8 insertions(+), 19 deletions(-)
diff --git a/api/src/main/java/org/apache/gravitino/rel/types/Types.java
b/api/src/main/java/org/apache/gravitino/rel/types/Types.java
index f0e9a20569..660ce3935f 100644
--- a/api/src/main/java/org/apache/gravitino/rel/types/Types.java
+++ b/api/src/main/java/org/apache/gravitino/rel/types/Types.java
@@ -654,10 +654,7 @@ public class Types {
}
}
- /**
- * The struct type in Gravitino. Note, this type is not supported in the
current version of
- * Gravitino.
- */
+ /** The struct type in Gravitino. */
public static class StructType extends Type.ComplexType {
/**
@@ -827,7 +824,7 @@ public class Types {
}
}
- /** A list type. Note, this type is not supported in the current version of
Gravitino. */
+ /** The list type in Gravitino. */
public static class ListType extends Type.ComplexType {
/**
@@ -912,10 +909,7 @@ public class Types {
}
}
- /**
- * The map type in Gravitino. Note, this type is not supported in the
current version of
- * Gravitino.
- */
+ /** The map type in Gravitino. */
public static class MapType extends Type.ComplexType {
/**
@@ -1009,10 +1003,7 @@ public class Types {
}
}
- /**
- * The union type in Gravitino. Note, this type is not supported in the
current version of
- * Gravitino.
- */
+ /** The union type in Gravitino. */
public static class UnionType extends Type.ComplexType {
/**
diff --git a/clients/client-python/gravitino/api/types/types.py
b/clients/client-python/gravitino/api/types/types.py
index b204fa82ad..8136796885 100644
--- a/clients/client-python/gravitino/api/types/types.py
+++ b/clients/client-python/gravitino/api/types/types.py
@@ -598,8 +598,7 @@ class Types:
return "binary"
class StructType(ComplexType):
- """The struct type in Gravitino.
- Note, this type is not supported in the current version of
Gravitino."""
+ """The struct type in Gravitino."""
_fields: List[Field]
@@ -741,8 +740,7 @@ class Types:
return f"{self._name}: {self._type.simple_string()}
{nullable_str}{comment_str}"
class ListType(ComplexType):
- """A list type. Note, this type is not supported in the current
version of Gravitino."""
-
+ """The list type in Gravitino."""
_element_type: Type
_element_nullable: bool
@@ -827,7 +825,7 @@ class Types:
return hash((self._element_type, self._element_nullable))
class MapType(ComplexType):
- """The map type in Gravitino. Note, this type is not supported in the
current version of Gravitino."""
+ """The map type in Gravitino."""
_key_type: Type
_value_type: Type
@@ -928,7 +926,7 @@ class Types:
return hash((self._key_type, self._value_type,
self._value_nullable))
class UnionType(ComplexType):
- """The union type in Gravitino. Note, this type is not supported in
the current version of Gravitino."""
+ """The union type in Gravitino."""
_types: list[Type]