FANNG1 commented on code in PR #6985:
URL: https://github.com/apache/gravitino/pull/6985#discussion_r2051882286
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/BaseGVFSOperations.java:
##########
@@ -369,6 +376,15 @@ protected long defaultBlockSize() {
return defaultBlockSize;
}
+ /**
+ * Whether to enable credential vending.
+ *
+ * @return true if credential vending is enabled, false otherwise.
+ */
+ protected boolean enableCredentialVending() {
Review Comment:
why this method is `protected`?
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/SecureHadoopCatalogOperations.java:
##########
@@ -262,17 +265,21 @@ public void testConnection(
@Override
public List<PathContext> getPathContext(NameIdentifier filesetIdentifier) {
Fileset fileset = loadFileset(filesetIdentifier);
- Map<String, String> locations = fileset.storageLocations();
- Preconditions.checkArgument(
- locations != null && !locations.isEmpty(),
- "No storage locations found for fileset: " + filesetIdentifier);
-
- // todo: support multiple storage locations
- String path =
locations.get(fileset.properties().get(PROPERTY_DEFAULT_LOCATION_NAME));
+ CallerContext callerContext = CallerContext.CallerContextHolder.get();
+ String targetLocationName =
Review Comment:
seems still not checked ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
