xunliu commented on code in PR #6929: URL: https://github.com/apache/gravitino/pull/6929#discussion_r2055199641
########## clients/client-python/.pre-commit-config.yaml: ########## @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Configuration file for the Sphinx documentation builder. +# +# For the full list of built-in configuration values, see the documentation: +# https://www.sphinx-doc.org/en/master/usage/configuration.html + +# -- Project information ----------------------------------------------------- +# https://www.sphinx-doc.org/en/master/usage/configuration.html#project-information + +repos: + - repo: https://github.com/psf/black + rev: 24.4.2 + hooks: + - id: black + language_version: python3 + + - repo: https://github.com/pycqa/flake8 + rev: 7.0.0 + hooks: + - id: flake8 + args: [--max-line-length=100] + additional_dependencies: [] Review Comment: hi @yunchipang Maybe we can use `ruff` to replace `flake8`, because `ruff` use `Rust` development, So `ruff` very fast. ``` repos: # Black code formatter - repo: https://github.com/psf/black rev: 25.1.0 hooks: - id: black args: ......? # isort import sorter - repo: https://github.com/pycqa/isort rev: 6.0.0 hooks: - id: isort name: isort (python) args: ......? # Ruff code linter - repo: https://github.com/astral-sh/ruff-pre-commit rev: v0.11.5 hooks: # Run the linter. - id: ruff # Run the formatter. - id: ruff-format ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
