mchades commented on code in PR #7100:
URL: https://github.com/apache/gravitino/pull/7100#discussion_r2065369686
##########
api/src/main/java/org/apache/gravitino/file/FilesetCatalog.java:
##########
@@ -185,4 +185,6 @@ default String getFileLocation(NameIdentifier ident, String
subPath, String loca
throws NoSuchFilesetException, NoSuchLocationNameException {
throw new UnsupportedOperationException("Not implemented");
}
+
+ String listFiles(NameIdentifier ident);
Review Comment:
I assume that `listFiles` will only be available in the REST API. If so, is
it necessary to add the `listFiles` method to the API module?
Perhaps we can add an interface called `FilesetFileOps` in the core module,
which includes the method `listFiles`. Otherwise, clients will see the
`listFiles` method but won't be able to use it, causing confusion. WDYT?
@jerryshao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
