yunchipang commented on code in PR #7103:
URL: https://github.com/apache/gravitino/pull/7103#discussion_r2066951658
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/converter/HiveDataTypeConverter.java:
##########
@@ -87,7 +87,17 @@ public TypeInfo fromGravitino(Type type) {
case DATE:
return getPrimitiveTypeInfo(DATE_TYPE_NAME);
case TIMESTAMP:
- return getPrimitiveTypeInfo(TIMESTAMP_TYPE_NAME);
+ if (type instanceof Types.TimestampType) {
+ Types.TimestampType tsType = (Types.TimestampType) type;
+ // Timestamps are interpreted to be timezoneless in Hive:
+ //
https://hive.apache.org/docs/latest/languagemanual-types_27838462/#timestamps
+ if (tsType.hasTimeZone()) {
Review Comment:
@mchades I have added the docs link and replace simple error message with
TIMESTAMP WITHOUT TIMEZONE type suggestion. Please take a look. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
