This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 87e429d3c2 [Minor] Improve error messages (#7127)
87e429d3c2 is described below
commit 87e429d3c23f4f3114158a4a9c15232d5bae510e
Author: Justin Mclean <[email protected]>
AuthorDate: Thu May 8 11:04:11 2025 +0800
[Minor] Improve error messages (#7127)
### What changes were proposed in this pull request?
Improve and clarify error messages.
### Why are the changes needed?
For clarity.
Fix: #(issue)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested locally.
---
build.gradle.kts | 16 +++++++++-------
clients/client-java-runtime/build.gradle.kts | 2 +-
clients/client-python/build.gradle.kts | 2 +-
common/build.gradle.kts | 2 +-
flink-connector/flink-runtime/build.gradle.kts | 2 +-
trino-connector/integration-test/build.gradle.kts | 4 ++--
6 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/build.gradle.kts b/build.gradle.kts
index 49f3b95ade..eeea595b86 100644
--- a/build.gradle.kts
+++ b/build.gradle.kts
@@ -50,8 +50,8 @@ plugins {
alias(libs.plugins.spotless)
} else {
throw GradleException(
- "Gravitino Gradle toolchain current doesn't support " +
- "Java version: ${JavaVersion.current()}. Please use JDK8 to 17."
+ "The Gravitino Gradle toolchain currently does not support " +
+ "Java version ${JavaVersion.current()}. Please use JDK versions 8
through 17."
)
}
@@ -66,14 +66,14 @@ plugins {
if (extra["jdkVersion"] !in listOf("8", "11", "17")) {
throw GradleException(
- "Gravitino current doesn't support building with " +
- "Java version: ${extra["jdkVersion"]}. Please use JDK8, 11 or 17."
+ "The Gravitino Gradle toolchain currently does not support building with "
+
+ "Java version ${extra["jdkVersion"]}. Please use JDK versions 8, 11 or
17."
)
}
val scalaVersion: String = project.properties["scalaVersion"] as? String ?:
extra["defaultScalaVersion"].toString()
if (scalaVersion !in listOf("2.12", "2.13")) {
- throw GradleException("Found unsupported Scala version: $scalaVersion")
+ throw GradleException("Scala version $scalaVersion is not supported.")
}
project.extra["extraJvmArgs"] = if (extra["jdkVersion"] in listOf("8", "11")) {
@@ -213,9 +213,11 @@ allprojects {
param.environment("GRAVITINO_WAR", project.rootDir.path +
"/web/web/dist/")
param.systemProperty("testMode", "embedded")
} else {
- throw GradleException("Gravitino integration tests only support
[-PtestMode=embedded] or [-PtestMode=deploy] mode!")
+ throw GradleException(
+ "Gravitino integration tests are only compatible with the modes " +
+ "[-PtestMode=embedded] or [-PtestMode=deploy]."
+ )
}
-
param.useJUnitPlatform()
val skipUTs = project.hasProperty("skipTests")
if (skipUTs) {
diff --git a/clients/client-java-runtime/build.gradle.kts
b/clients/client-java-runtime/build.gradle.kts
index a3b889b390..f3747adb81 100644
--- a/clients/client-java-runtime/build.gradle.kts
+++ b/clients/client-java-runtime/build.gradle.kts
@@ -27,7 +27,7 @@ plugins {
configurations.all {
resolutionStrategy.eachDependency {
if (requested.group == "org.apache.logging.log4j") {
- throw GradleException("Forbidden dependency 'org.apache.logging.log4j'
found!")
+ throw GradleException("Dependency 'org.apache.logging.log4j' is not
allowed.")
}
}
}
diff --git a/clients/client-python/build.gradle.kts
b/clients/client-python/build.gradle.kts
index 436085a083..43c3bb65a2 100644
--- a/clients/client-python/build.gradle.kts
+++ b/clients/client-python/build.gradle.kts
@@ -147,7 +147,7 @@ fun generatePypiProjectHomePage() {
val readmeFile = file("README.md")
readmeFile.writeText(contentUpdateImage)
} catch (e: Exception) {
- throw GradleException("client-python README.md file not generated!")
+ throw GradleException("Failed to generate client-python/README.md.")
}
}
diff --git a/common/build.gradle.kts b/common/build.gradle.kts
index 1acf0e1b4c..adb93a389b 100644
--- a/common/build.gradle.kts
+++ b/common/build.gradle.kts
@@ -121,7 +121,7 @@ tasks {
doFirst() {
writeProjectPropertiesFile()
if (!file(propertiesFile).exists()) {
- throw GradleException("$propertiesFile file not generated!")
+ throw GradleException("Failed to generate $propertiesFile.")
}
}
diff --git a/flink-connector/flink-runtime/build.gradle.kts
b/flink-connector/flink-runtime/build.gradle.kts
index 0ac393dedf..87a3a85fb2 100644
--- a/flink-connector/flink-runtime/build.gradle.kts
+++ b/flink-connector/flink-runtime/build.gradle.kts
@@ -44,7 +44,7 @@ val baseName =
"${rootProject.name}-flink-connector-runtime-${flinkMajorVersion}
configurations.all {
resolutionStrategy.eachDependency {
if (requested.group == "org.apache.logging.log4j") {
- throw GradleException("Forbidden dependency 'org.apache.logging.log4j'
found!")
+ throw GradleException("Dependency 'org.apache.logging.log4j' is not
allowed.")
}
}
}
diff --git a/trino-connector/integration-test/build.gradle.kts
b/trino-connector/integration-test/build.gradle.kts
index d3f483ab60..3c85c80d5d 100644
--- a/trino-connector/integration-test/build.gradle.kts
+++ b/trino-connector/integration-test/build.gradle.kts
@@ -109,9 +109,9 @@ tasks.test {
}
if (invalidGravitinoJars!!.isNotEmpty()) {
- val message = "Found mismatched versions of gravitino jars in
trino-connector/build/libs:\n" +
+ val message = "Mismatched Gravitino JAR versions found in
trino-connector/build/libs:\n" +
"${invalidGravitinoJars.joinToString(", ") { it.name }}\n" +
- "The current version of the project is $version. Please clean the
project and rebuild it."
+ "The expected project version is $version. Please clean and
rebuild the project."
throw GradleException(message)
}
}
