FANNG1 commented on code in PR #7174:
URL: https://github.com/apache/gravitino/pull/7174#discussion_r2099158104
##########
dev/charts/gravitino-iceberg-rest-server/templates/deployment.yaml:
##########
@@ -0,0 +1,174 @@
+{{- /*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ */}}
+
+# Kubernetes Deployment Manifest for Gravitino Iceberg REST Server
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ include "gravitino-iceberg-rest-server.fullname" . }}
+ namespace: {{ include "gravitino-iceberg-rest-server.namespace" . }}
+ labels:
+ {{- include "gravitino-iceberg-rest-server.labels" . | nindent 4 }}
+ annotations:
+ {{- toYaml .Values.annotations | nindent 4 }}
+
+spec:
+ replicas: {{ .Values.replicas }}
+
+ # Selector for managing Pods
+ selector:
+ matchLabels:
+ app: {{ include "gravitino-iceberg-rest-server.name" . }}
+ release: {{ .Release.Name }}
+
+ template:
+ metadata:
+ # Pod annotations (if configured)
+ {{- with .Values.podAnnotations }}
+ annotations:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+
+ labels:
+ app: {{ include "gravitino-iceberg-rest-server.name" . }}
+ name: {{ include "gravitino-iceberg-rest-server.fullname" . }}
+ release: {{ .Release.Name }}
+ # Additional pod labels
+ {{- with .Values.podLabels }}
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+
+ spec:
+ # Image pull secrets configuration
+ {{- with .Values.image.pullSecrets }}
+ imagePullSecrets:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+
+ serviceAccountName: {{ include
"gravitino-iceberg-rest-server.serviceAccountName" . }}
+
+ # Pod-level security context
+ securityContext:
+ {{- toYaml .Values.podSecurityContext | nindent 8 }}
+
+ containers:
+ - name: {{ include "gravitino-iceberg-rest-server.name" . }}
+ # Image configuration
+ image: "{{ .Values.image.repository }}:{{ .Values.image.tag |
default .Chart.AppVersion }}"
+ imagePullPolicy: {{ .Values.image.pullPolicy }}
+ command:
+ - "/bin/bash"
+ - "/tmp/conf/init.sh"
+
+ # Container security context
+ securityContext:
+ {{- toYaml .Values.securityContext | nindent 12 }}
+
+ # Environment variables
+ {{- if .Values.env }}
+ env:
+ {{- toYaml .Values.env | nindent 12 }}
+ {{- end }}
+
+ # Environment from ConfigMaps/Secrets
+ {{- if .Values.envFrom }}
+ envFrom:
+ {{- toYaml .Values.envFrom | nindent 12 }}
+ {{- end }}
+
+ # Container ports
+ ports:
+ - name: {{ .Values.service.portName }}
+ containerPort: {{ .Values.service.port }}
+ protocol: TCP
+
+ # Probes configuration
+ livenessProbe:
+ {{- toYaml .Values.livenessProbe | nindent 12 }}
+
+ readinessProbe:
+ {{- toYaml .Values.readinessProbe | nindent 12 }}
+
+ # Resource limits/requests
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
+
+ # Volume mounts
+ volumeMounts:
+ - name: iceberg-rest-server-config
+ mountPath: /tmp/conf/
+
+ {{- if .Values.extraVolumeMounts }}
+ # Additional volume mounts
+ {{- toYaml .Values.extraVolumeMounts | nindent 12 }}
+ {{- end }}
+
+ # Node scheduling constraints
+ {{- with .Values.nodeSelector }}
+ nodeSelector:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+
+ {{- with .Values.affinity }}
+ affinity:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+
+ {{- with .Values.tolerations }}
+ tolerations:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+
+ volumes:
+ # Configuration volume
+ - name: iceberg-rest-server-config
+ configMap:
+ name: {{ include "gravitino-iceberg-rest-server.fullname" . }}
+
+ # Storage volume configuration
+ {{- if not .Values.persistence.enabled }}
+ - name: storage
Review Comment:
> @FANNG1 The gravitino-iceberg-rest-server don't need the persistence
storage volume, right?
yes, seems not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
