jerryshao commented on code in PR #7181: URL: https://github.com/apache/gravitino/pull/7181#discussion_r2101481585
########## core/src/main/java/org/apache/gravitino/cache/RelationEntityCacheKey.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cache; + +import com.google.common.base.Preconditions; +import java.util.Objects; +import org.apache.gravitino.Entity; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.SupportsRelationOperations; + +/** Key for caching relation entities. */ +public class RelationEntityCacheKey { + private final NameIdentifier identifier; + private final Entity.EntityType type; + private final SupportsRelationOperations.Type relationType; + + /** + * Creates a new instance of {@link RelationEntityCacheKey} with the given parameters. + * + * @param ident The identifier of the entity. + * @param type The type of the entity. + * @param relationType The type of the relation. + * @return A new instance of {@link RelationEntityCacheKey}. + */ + public static RelationEntityCacheKey of( + NameIdentifier ident, Entity.EntityType type, SupportsRelationOperations.Type relationType) { + return new RelationEntityCacheKey(ident, type, relationType); + } + + /** + * Creates a new instance of {@link RelationEntityCacheKey} with the given parameters. + * + * @param storeEntityCacheKey The {@link StoreEntityCacheKey} instance. + * @param relationType The type of the relation. + * @return A new instance of {@link RelationEntityCacheKey}. + */ + public static RelationEntityCacheKey of( + StoreEntityCacheKey storeEntityCacheKey, SupportsRelationOperations.Type relationType) { + return new RelationEntityCacheKey( + storeEntityCacheKey.identifier(), storeEntityCacheKey.type(), relationType); + } + + /** + * Creates a new instance of {@link RelationEntityCacheKey} with the given parameters. + * + * @param identifier The identifier of the entity. + * @param type The type of the entity. + * @param relationType The type of the relation. + */ + public RelationEntityCacheKey( Review Comment: Do you need to make this `private`, since you already have a static method to create the key? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
