slimtom95 opened a new issue, #7225:
URL: https://github.com/apache/gravitino/issues/7225
### Version
main branch
### Describe what's wrong
While testing python sdk I find a few minor issues, which should be easy to
fix.
1. storage handlers misconfig
`gravitino/clients/client-python/gravitino/filesystem/gvfs_storage_handler.py`
```
LOCA_HANDLER = LocalStorageHandler()
HDFS_HANDLER = HDFSStorageHandler()
S3_HANDLER = S3StorageHandler()
GCS_HANDLER = GCSStorageHandler()
OSS_HANDLER = OSSStorageHandler()
ABS_HANDLER = ABSStorageHandler()
```
```
storage_handlers: Dict[StorageType, StorageHandler] = {
StorageType.LOCAL: LOCA_HANDLER,
StorageType.HDFS: HDFS_HANDLER,
StorageType.GCS: GCS_HANDLER,
StorageType.S3A: S3StorageHandler,
StorageType.OSS: OSSSecretKeyCredential,
StorageType.ABS: AzureAccountKeyCredential,
}
```
Clearly, `StorageType.S3A: S3StorageHandler` should be `StorageType.S3A:
S3_HANDLER`. I wasn't test with oss and abs, but it seems to be wrong as well.
2. s3 config `-` and `_` mess
`clients/client-python/gravitino/filesystem/gvfs_config.py`
```
GVFS_FILESYSTEM_S3_ACCESS_KEY = "s3_access_key_id"
GVFS_FILESYSTEM_S3_SECRET_KEY = "s3_secret_access_key"
GVFS_FILESYSTEM_S3_ENDPOINT = "s3_endpoint"
```
In the constant config module, we have config item value with `_`.
`clients/client-python/gravitino/filesystem/gvfs_storage_handler.py`
```
s3_endpoint = catalog_props.get("s3-endpoint", None) if
catalog_props else None
```
While in storage handler module, using `-` (also mind the hardcode).
We probably should eliminate the hardcode and change the config name from
`_` to `-` to align with other sdk.
(For now, I have to use `s3-endpoint` and `s3_secret_access_key`,
`s3_access_key_id` for connection, werid right?)
### Error message and/or stacktrace
No error needed i think, the issue and fix should be quite clearly to
everyone.
### How to reproduce
No reproduce procedure needed i think, the issue and fix should be quite
clearly to everyone.
### Additional context
apache-gravitino==0.9.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
