justinmclean commented on code in PR #7233:
URL: https://github.com/apache/gravitino/pull/7233#discussion_r2106348353
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/dyn/DynFields.java:
##########
@@ -109,12 +109,20 @@ public StaticField<T> asStatic() {
return new StaticField<>(this);
}
- /** Returns whether the field is a static field. */
+ /**
+ * Returns whether the field is a static field.
+ *
+ * @return true if the field is static; false otherwise
+ */
public boolean isStatic() {
return Modifier.isStatic(field.getModifiers());
}
- /** Returns whether the field is always null. */
+ /**
+ * Returns whether the field is always null.
+ *
+ * @return true if this instance is the AlwaysNull sentinel; false
otherwise
Review Comment:
I don't think that sentinel is the correct term here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
