KyleLin0927 commented on code in PR #7235:
URL: https://github.com/apache/gravitino/pull/7235#discussion_r2106375593
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java:
##########
@@ -219,9 +219,17 @@ protected boolean isSystemDatabase(String dbName) {
return
createSysDatabaseNameSet().contains(dbName.toLowerCase(Locale.ROOT));
}
- /** Check whether support setting schema comment. */
+ /**
+ * Check whether support setting schema comment.
+ *
+ * @return true if schema comments are supported; false otherwise.
+ */
protected abstract boolean supportSchemaComment();
- /** Create a set of system database names. */
+ /**
+ * Create a set of system database names.
+ *
+ * @return a set of system database names in lowercase.
Review Comment:
Hi @justinmclean , thanks for your review, the implementation returns
lowercase. If you’d like me to remove the ‘in lowercase’ part I can take care
of that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
