aaryansinhaa commented on issue #7282:
URL: https://github.com/apache/gravitino/issues/7282#issuecomment-2915934980
Hey @justinmclean ,
I am interested in this issue, and am working in it, I checked the three
files that you have given:
For Example, In
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java
the current log statement is:
` LOG.info("Generated alter table:{} sql: {}", databaseName + "." +
tableName, result);`
the change I am thinking is:
`LOG.info("Generated alter table: {}.{} sql: {}", databaseName, tableName,
result)`
I have a few questions too:
1. While reviewing other parts of the codebase, I noticed that some log
statements already use SLF4J’s formatting, while others use concatenation.
Should I update all such `LOG.info` entries across the codebase?
2. Should I also fix similar patterns in `LOG.debug`, `LOG.warn`, or
`LOG.error` if I find any?
The built in formatting will utilise SLF4J lazy evaluation and will help in
reducing the concatenation overhead
This is my first contribution to open source and would love to know any
resources that you would like me to refer to!
Looking forward to contribute!
Thanks,
Aaryan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
