(gravitino) branch main updated: [#7285][Improvements] Use equalsIgnoreCase instead of upperCase.equals (#7306)

[jshao]

This is an automated email from the ASF dual-hosted git repository.

jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 2658dc64df [#7285][Improvements] Use equalsIgnoreCase instead of 
upperCase.equals (#7306)
2658dc64df is described below

commit 2658dc64df54d59ea9f5007165c50da3588aac4b
Author: Gagan B Mishra <gagan.mis...@gmail.com>
AuthorDate: Fri May 30 00:06:16 2025 -0700

    [#7285][Improvements] Use equalsIgnoreCase instead of upperCase.equals 
(#7306)
    
    ### What changes were proposed in this pull request?
    
    Replacing `toUpperCase().equals` with single `equalsIgnoreCase`
    
    ### Why are the changes needed?
    
    For better code readability
    
    Fix: #7285
    
    ### Does this PR introduce _any_ user-facing change?
    
    N/A
    
    ### How was this patch tested?
    
    ./gradlew clean build
---
 .../gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java
 
b/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java
index ad4ea596a5..192ce53b22 100644
--- 
a/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java
+++ 
b/trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java
@@ -273,7 +273,7 @@ public class ExpressionUtil {
                 (m) -> {
                   NamedReference.FieldReference sortField = 
NamedReference.field(m.group(1));
                   SortDirection sortDirection =
-                      m.group(1).toUpperCase().equals(SORT_DIRECTION_ASC)
+                      m.group(1).equalsIgnoreCase(SORT_DIRECTION_ASC)
                           ? SortDirection.ASCENDING
                           : SortDirection.DESCENDING;
                   NullOrdering nullOrdering =
@@ -288,11 +288,11 @@ public class ExpressionUtil {
                 (m) -> {
                   NamedReference.FieldReference sortField = 
NamedReference.field(m.group(1));
                   SortDirection sortDirection =
-                      m.group(2).toUpperCase().equals(SORT_DIRECTION_ASC)
+                      m.group(2).equalsIgnoreCase(SORT_DIRECTION_ASC)
                           ? SortDirection.ASCENDING
                           : SortDirection.DESCENDING;
                   NullOrdering nullOrdering =
-                      m.group(3).toUpperCase().equals(NULL_ORDERING_FIRST)
+                      m.group(3).equalsIgnoreCase(NULL_ORDERING_FIRST)
                           ? NullOrdering.NULLS_FIRST
                           : NullOrdering.NULLS_LAST;
                   sortOrders.add(SortOrders.of(sortField, sortDirection, 
nullOrdering));