mchades commented on code in PR #7362:
URL: https://github.com/apache/gravitino/pull/7362#discussion_r2135203376
##########
clients/client-java/src/main/java/org/apache/gravitino/client/BaseSchemaCatalog.java:
##########
@@ -82,17 +82,21 @@ abstract class BaseSchemaCatalog extends CatalogDTO
catalogNamespace != null && catalogNamespace.length() == 1,
"Catalog namespace must be non-null and have 1 level, the input
namespace is %s",
catalogNamespace);
+
this.catalogNamespace = catalogNamespace;
+ String namespaceName = catalogNamespace.level(0);
+ Namespace.check(namespaceName != null && !namespaceName.isEmpty(),
Review Comment:
could you plz add tests to cover the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
