Jackeyzhe commented on code in PR #7361:
URL: https://github.com/apache/gravitino/pull/7361#discussion_r2135753258
##########
core/src/main/java/org/apache/gravitino/storage/relational/utils/POConverters.java:
##########
@@ -1305,6 +1385,74 @@ public static TagMetadataObjectRelPO
initializeTagMetadataObjectRelPOWithVersion
}
}
+ public static PolicyEntity fromPolicyPO(PolicyPO policyPO, Namespace
namespace) {
+ try {
+ return PolicyEntity.builder()
+ .withId(policyPO.getPolicyId())
+ .withName(policyPO.getPolicyName())
+ .withNamespace(namespace)
+ .withType(policyPO.getPolicyType())
+ .withComment(policyPO.getPolicyVersionPO().getPolicyComment())
Review Comment:
Do you think it should check if the policyVersion is null here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
