Abyss-lord commented on code in PR #7366:
URL: https://github.com/apache/gravitino/pull/7366#discussion_r2137195289
##########
clients/cli/src/main/java/org/apache/gravitino/cli/Providers.java:
##########
@@ -27,6 +27,7 @@
* Gravitino CLI. It also can validate if a given entity is a valid entity.
*/
public class Providers {
+
Review Comment:
plz remove the blank line.
##########
clients/cli/src/main/java/org/apache/gravitino/cli/Providers.java:
##########
@@ -85,6 +88,8 @@ public static String internal(String provider) {
return "lakehouse-hudi";
case OCEANBASE:
return "jdbc-oceanbase";
+ case MODEL:
+ return "model"; // Handle MODEL provider and return internal provider
name
Review Comment:
ditto.
##########
clients/cli/src/main/java/org/apache/gravitino/cli/Providers.java:
##########
@@ -105,6 +110,8 @@ public static Catalog.Type catalogType(String provider) {
return Catalog.Type.RELATIONAL;
case KAFKA:
return Catalog.Type.MESSAGING;
+ case MODEL: // Set catalog type to MODEL for model provider
+ return Catalog.Type.MODEL;
Review Comment:
You should add the test cases in `TestProviders` and remove the comments.
The logic is very simple that no comments are needed.
##########
clients/cli/src/main/java/org/apache/gravitino/cli/Providers.java:
##########
@@ -51,6 +53,7 @@ public class Providers {
VALID_PROVIDERS.add(PAIMON);
VALID_PROVIDERS.add(HUDI);
VALID_PROVIDERS.add(OCEANBASE);
+ VALID_PROVIDERS.add(MODEL); // Add MODEL to the valid providers set
Review Comment:
ditto.
##########
clients/cli/src/main/java/org/apache/gravitino/cli/Providers.java:
##########
@@ -37,6 +38,7 @@ public class Providers {
public static final String PAIMON = "paimon";
public static final String HUDI = "hudi";
public static final String OCEANBASE = "oceanbase";
+ public static final String MODEL = "model"; // Add MODEL provider constant
definition
Review Comment:
This comment may no longer be necessary, plz remove the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
