yuqi1129 commented on PR #7393: URL: https://github.com/apache/gravitino/pull/7393#issuecomment-2984311193
> @yuqi1129 Hi, could you please give me some advice? @kaori-seasons Thanks for your hard work, overall, I have the following concerns: 1. Class loader sharing is a complex issue. Different class loaders sharing the same class may lead to some unknown problems. For instance, some static instances are mutable and can be changed by one catalog, which will be used by other catalogs that share the class loaders. 2. The core issue seems to remain unresolved. I have tested that the class loader can't be cleaned by GC even though it has been closed and all classes it loaded are released. Considering the cases that there are plenty of catalogs at the same time, say 100, and only 10 of them are active, the memory occupied by metaspace will be `25MB * 100 = 2.5GB` though only 250MB are sufficient, it can easily cause OOM. Your solution can resolve the problem if modifications mainly focus on properties that don't need to create a new class loader. 3. Statistics and rate limits are crucial. I appreciate you introducing these works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
