xunliu commented on code in PR #7450:
URL: https://github.com/apache/gravitino/pull/7450#discussion_r2174051029
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -285,6 +285,13 @@ private Configs() {}
.booleanConf()
.createWithDefault(false);
+ public static final ConfigEntry<String> AUTHORIZATION_TYPE =
+ new ConfigBuilder("gravitino.authorization.type")
+ .doc("Enable the authorization")
+ .version(ConfigConstants.VERSION_1_0_0)
+ .stringConf()
+ .createWithDefault("pass");
Review Comment:
```
public static final ConfigEntry<String> AUTHORIZATION_IMPL =
new ConfigBuilder("gravitino.authorization.impl")
.doc("Metadata authorization implement")
.version(ConfigConstants.VERSION_1_0_0)
.stringConf()
.createWithDefault("PassThrough");
```
##########
server/src/main/java/org/apache/gravitino/server/web/filter/GravitinoInterceptionService.java:
##########
@@ -82,23 +83,28 @@ private static class MetadataAuthorizationMethodInterceptor
implements MethodInt
*/
@Override
public Object invoke(MethodInvocation methodInvocation) throws Throwable {
- Method method = methodInvocation.getMethod();
- Parameter[] parameters = method.getParameters();
- AuthorizationExpression expressionAnnotation =
- method.getAnnotation(AuthorizationExpression.class);
- if (expressionAnnotation != null) {
- String expression = expressionAnnotation.expression();
- Object[] args = methodInvocation.getArguments();
- Map<Entity.EntityType, NameIdentifier> metadataContext =
- extractNameIdentifierFromParameters(parameters, args);
- AuthorizationExpressionEvaluator authorizationExpressionEvaluator =
- new AuthorizationExpressionEvaluator(expression);
- boolean authorizeResult =
authorizationExpressionEvaluator.evaluate(metadataContext);
- if (!authorizeResult) {
- return Utils.internalError("Can not access metadata.");
+ try {
+ Method method = methodInvocation.getMethod();
+ Parameter[] parameters = method.getParameters();
+ AuthorizationExpression expressionAnnotation =
+ method.getAnnotation(AuthorizationExpression.class);
+ if (expressionAnnotation != null) {
+ String expression = expressionAnnotation.expression();
+ Object[] args = methodInvocation.getArguments();
+ Map<Entity.EntityType, NameIdentifier> metadataContext =
+ extractNameIdentifierFromParameters(parameters, args);
+ AuthorizationExpressionEvaluator authorizationExpressionEvaluator =
+ new AuthorizationExpressionEvaluator(expression);
+ boolean authorizeResult =
authorizationExpressionEvaluator.evaluate(metadataContext);
+ if (!authorizeResult) {
+ return Utils.forbidden(
+ "Can not access metadata.", new ForbiddenException("Can not
access metadata."));
+ }
Review Comment:
```
"Can not access metadata {metalake1.catalog1.xxxx}.", new
ForbiddenException("Can not access metadata {metalake1.catalog1.xxxx}."));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
