jerqi commented on code in PR #7333: URL: https://github.com/apache/gravitino/pull/7333#discussion_r2174347063
########## api/src/main/java/org/apache/gravitino/stats/SupportsStatistics.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.stats; + +import java.util.List; +import java.util.Map; +import org.apache.gravitino.annotation.Evolving; +import org.apache.gravitino.exceptions.IllegalStatisticNameException; +import org.apache.gravitino.exceptions.UnmodifiableStatisticException; + +/** + * SupportsStatistics provides methods to list and update statistics. A table, a partition or a + * fileset can implement this interface to manage its statistics. + */ +@Evolving +public interface SupportsStatistics { + + /** + * Lists all statistics. + * + * @return a list of statistics + */ + List<Statistic> listStatistics(); + + /** + * Updates statistics with the provided values. If the statistic exists, it will be updated with + * the new value. If the statistic does not exist, it will be created. If the statistic is + * unmodifiable, it will throw an UnmodifiableStatisticException. If the statistic name is + * illegal, it will throw an IllegalStatisticNameException. + * + * @param statistics a map of statistic names to their values + * @return a list of updated statistics + */ + List<Statistic> updateStatistics(Map<String, StatisticValue> statistics) Review Comment: I addressed the warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
