xiaozcy commented on code in PR #7502:
URL: https://github.com/apache/gravitino/pull/7502#discussion_r2176332169
##########
core/src/main/java/org/apache/gravitino/storage/relational/utils/POConverters.java:
##########
@@ -1474,21 +1484,31 @@ public static List<ModelVersionAliasRelPO>
updateModelVersionAliasRelPO(
}
}
- public static ModelVersionPO initializeModelVersionPO(
- ModelVersionEntity modelVersionEntity, ModelVersionPO.Builder builder) {
+ public static List<ModelVersionPO> initializeModelVersionPO(
+ ModelVersionEntity modelVersionEntity, Long modelId) {
try {
- return builder
- // Note that version set here will not be used when inserting into
database, it will
- // directly use the version from the query to avoid concurrent
version conflict.
- .withModelVersion(modelVersionEntity.version())
- .withModelVersionComment(modelVersionEntity.comment())
- .withModelVersionUri(modelVersionEntity.uri())
- .withModelVersionProperties(
-
JsonUtils.anyFieldMapper().writeValueAsString(modelVersionEntity.properties()))
- .withAuditInfo(
-
JsonUtils.anyFieldMapper().writeValueAsString(modelVersionEntity.auditInfo()))
- .withDeletedAt(DEFAULT_DELETED_AT)
- .build();
+ String modelVersionProperties =
+
JsonUtils.anyFieldMapper().writeValueAsString(modelVersionEntity.properties());
+ String modelVersionAuditInfo =
+
JsonUtils.anyFieldMapper().writeValueAsString(modelVersionEntity.auditInfo());
+ return modelVersionEntity.uris().entrySet().stream()
+ .map(
+ entry ->
+ ModelVersionPO.builder()
+ .withModelId(modelId)
+ // Note that version set here will not be used when
inserting into database,
+ // it will
+ // directly use the version from the query to avoid
concurrent version
Review Comment:
Fixed.
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/ModelVersionMetaService.java:
##########
@@ -321,26 +329,53 @@ public <E extends Entity & HasIdentifier>
ModelVersionEntity updateModelVersion(
try {
SessionUtils.doMultipleWithCommit(
() ->
- updateResult.set(
+ updateResult.addAndGet(
SessionUtils.doWithoutCommitAndFetchResult(
ModelVersionMetaMapper.class,
mapper ->
mapper.updateModelVersionMeta(
POConverters.updateModelVersionPO(
- oldModelVersionPO, newModelVersionEntity),
- oldModelVersionPO))),
+ oldModelVersionPOs.get(0),
newModelVersionEntity),
+ oldModelVersionPOs.get(0)))),
+ // TODO Only modifying the unknown URI is supported currently.
+ () ->
+ oldModelVersionPOs.stream()
+ .filter(
+ v ->
+
ModelVersion.URI_NAME_UNKNOWN.equals(v.getModelVersionUriName())
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
