This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new fe020ea3f6 Add s3-path-style-access variable to iceberg-rest docker
(#7508)
fe020ea3f6 is described below
commit fe020ea3f654edcd488668af839fe5f5a3c8bdb8
Author: Yftach Zur <[email protected]>
AuthorDate: Tue Jul 1 14:49:11 2025 +0200
Add s3-path-style-access variable to iceberg-rest docker (#7508)
### What changes were proposed in this pull request?
Completing [pr/6541](https://github.com/apache/gravitino/pull/6541) -
making sure s3 path style access variable is added into the Dockerfile
for the Iceberg Rest Service
### Why are the changes needed?
The support for this variable was added, but not into the Dockerfile
that re-writes the conf file Gravitino starts with
Fix:[ #(6504)](https://github.com/apache/gravitino/issues/6504)
### Does this PR introduce _any_ user-facing change?
Only allowing users to set this variable when using the Iceberg Rest
Service docker image
### How was this patch tested?
ran `./gradlew.sh test`
---
dev/docker/iceberg-rest-server/rewrite_config.py | 1 +
docs/iceberg-rest-service.md | 1 +
2 files changed, 2 insertions(+)
diff --git a/dev/docker/iceberg-rest-server/rewrite_config.py
b/dev/docker/iceberg-rest-server/rewrite_config.py
index 3f1be57c7c..9171cbb118 100755
--- a/dev/docker/iceberg-rest-server/rewrite_config.py
+++ b/dev/docker/iceberg-rest-server/rewrite_config.py
@@ -34,6 +34,7 @@ env_map = {
"GRAVITINO_S3_SECRET_KEY": "s3-secret-access-key",
"GRAVITINO_S3_ENDPOINT": "s3-endpoint",
"GRAVITINO_S3_REGION": "s3-region",
+ "GRAVITINO_S3_PATH_STYLE_ACCESS": "s3-path-style-access",
"GRAVITINO_S3_ROLE_ARN": "s3-role-arn",
"GRAVITINO_S3_EXTERNAL_ID": "s3-external-id",
"GRAVITINO_AZURE_STORAGE_ACCOUNT_NAME": "azure-storage-account-name",
diff --git a/docs/iceberg-rest-service.md b/docs/iceberg-rest-service.md
index d3a342ab84..aeb683e63a 100644
--- a/docs/iceberg-rest-service.md
+++ b/docs/iceberg-rest-service.md
@@ -583,6 +583,7 @@ Gravitino Iceberg REST server in docker image could access
local storage by defa
| `GRAVITINO_S3_ROLE_ARN` |
`gravitino.iceberg-rest.s3-role-arn` | 0.7.0-incubating |
| `GRAVITINO_S3_EXTERNAL_ID` |
`gravitino.iceberg-rest.s3-external-id` | 0.7.0-incubating |
| `GRAVITINO_S3_TOKEN_SERVICE_ENDPOINT` |
`gravitino.iceberg-rest.s3-token-service-endpoint` | 0.8.0-incubating |
+| `GRAVITINO_S3_PATH_STYLE_ACCESS` |
`gravitino.iceberg-rest.s3-path-style-access` | 1.0.0 |
| `GRAVITINO_AZURE_STORAGE_ACCOUNT_NAME` |
`gravitino.iceberg-rest.azure-storage-account-name` | 0.8.0-incubating |
| `GRAVITINO_AZURE_STORAGE_ACCOUNT_KEY` |
`gravitino.iceberg-rest.azure-storage-account-key` | 0.8.0-incubating |
| `GRAVITINO_AZURE_TENANT_ID` |
`gravitino.iceberg-rest.azure-tenant-id` | 0.8.0-incubating |