pjfanning commented on code in PR #7548:
URL: https://github.com/apache/gravitino/pull/7548#discussion_r2179560557


##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/utils/DataSourceUtils.java:
##########
@@ -76,6 +78,41 @@ private static Properties getProperties(JdbcConfig 
jdbcConfig) {
     return properties;
   }
 
+  private static void validateJdbcConfig(JdbcConfig jdbcConfig) {
+    String driver = jdbcConfig.getJdbcDriver();
+    String url = jdbcConfig.getJdbcUrl();
+    Map<String, String> all = jdbcConfig.getAllConfig();
+    String lowerUrl = url == null ? "" : url.toLowerCase();
+
+    if (driver != null && driver.toLowerCase().contains("mysql")) {

Review Comment:
   mariadb has a lot of the same issues as mysql 
   
https://github.com/search?q=repo%3Amariadb-corporation%2Fmariadb-connector-j%20allowLocal&type=code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to