hdygxsj commented on code in PR #7536:
URL: https://github.com/apache/gravitino/pull/7536#discussion_r2181943661
##########
core/src/main/java/org/apache/gravitino/hook/AccessControlHookDispatcher.java:
##########
@@ -132,7 +135,9 @@ public Group revokeRolesFromGroup(String metalake,
List<String> roles, String gr
@Override
public User revokeRolesFromUser(String metalake, List<String> roles, String
user)
throws NoSuchUserException, IllegalRoleException,
NoSuchMetalakeException {
- return dispatcher.revokeRolesFromUser(metalake, roles, user);
+ User userAfterRevoke = dispatcher.revokeRolesFromUser(metalake, roles,
user);
+ notifyRoleUserRelChange(metalake, roles);
+ return userAfterRevoke;
Review Comment:
fixed
##########
core/src/main/java/org/apache/gravitino/hook/AccessControlHookDispatcher.java:
##########
@@ -191,13 +196,33 @@ public String[] listRoleNamesByObject(String metalake,
MetadataObject object)
public Role grantPrivilegeToRole(
String metalake, String role, MetadataObject object, Set<Privilege>
privileges)
throws NoSuchMetalakeException, NoSuchRoleException {
- return dispatcher.grantPrivilegeToRole(metalake, role, object, privileges);
+ Role roleAfterGrant = dispatcher.grantPrivilegeToRole(metalake, role,
object, privileges);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
