xiaozcy commented on code in PR #7502:
URL: https://github.com/apache/gravitino/pull/7502#discussion_r2181967625
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/ModelVersionMetaBaseSQLProvider.java:
##########
@@ -26,51 +28,60 @@
public class ModelVersionMetaBaseSQLProvider {
- public String insertModelVersionMeta(@Param("modelVersionMeta")
ModelVersionPO modelVersionPO) {
- return "INSERT INTO "
+ public String insertModelVersionMetas(
+ @Param("modelVersionMetas") List<ModelVersionPO> modelVersionPOs) {
+ return "<script>"
+ + "INSERT INTO "
+ ModelVersionMetaMapper.TABLE_NAME
- + "(metalake_id, catalog_id, schema_id, model_id, version,"
- + " model_version_comment, model_version_properties,
model_version_uri,"
- + " audit_info, deleted_at)"
- + " SELECT metalake_id, catalog_id, schema_id, model_id,
model_latest_version,"
- + " #{modelVersionMeta.modelVersionComment},
#{modelVersionMeta.modelVersionProperties},"
- + " #{modelVersionMeta.modelVersionUri},
#{modelVersionMeta.auditInfo},"
- + " #{modelVersionMeta.deletedAt}"
+ + "(metalake_id, catalog_id, schema_id, model_id, version,
model_version_comment,"
+ + " model_version_properties, model_version_uri_name,
model_version_uri, audit_info, deleted_at)"
+ + " SELECT m.metalake_id, m.catalog_id, m.schema_id, m.model_id,
m.model_latest_version, v.model_version_comment,"
+ + " v.model_version_properties, v.model_version_uri_name,
v.model_version_uri, v.audit_info, v.deleted_at"
+ + " FROM ("
+ + "<foreach collection='modelVersionMetas' item='version'
separator='UNION ALL'>"
+ + " SELECT"
+ + " #{version.modelId} AS model_id, #{version.modelVersionComment} AS
model_version_comment,"
+ + " #{version.modelVersionProperties} AS model_version_properties,
#{version.auditInfo} AS audit_info,"
+ + " #{version.deletedAt} AS deleted_at, #{version.modelVersionUriName}
AS model_version_uri_name,"
+ + " #{version.modelVersionUri} AS model_version_uri "
+ + "</foreach>"
+ + " ) v"
+ + " JOIN"
+ + " (SELECT metalake_id, catalog_id, schema_id, model_id,
model_latest_version"
+ " FROM "
+ ModelMetaMapper.TABLE_NAME
- + " WHERE model_id = #{modelVersionMeta.modelId} AND deleted_at = 0";
+ + " WHERE model_id = #{modelVersionMetas[0].modelId} AND deleted_at =
0) m"
+ + " ON v.model_id = m.model_id"
+ + "</script>";
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
