FANNG1 commented on PR #7567: URL: https://github.com/apache/gravitino/pull/7567#issuecomment-3034031215
> @FANNG1 I was wondering besides unit tests in `TestIcebergTableOperations`, which integration tests should be added/updated in this case? Guessing something under `org.apache.gravitino.iceberg.integration.test` but not sure which one(s). > > I'm still working on this PR, feel free to take a quick look whenever you have time and lmk if it's on the right track. thanks! The current solution LGTM, `org.apache.gravitino.iceberg.integration.test` is the place to place integrate test , but maybe some blocking issues: 1. Iceberg REST server doesn't support passing user information for now, could we do the auth IT without user information? 2. current integration test using a standalone Iceberg rest server, and it couldn't access the entity store which means the auth doesn't works for it. we should start a Iceberg REST server in aux mode, please refer to https://gravitino.apache.org/docs/0.9.0-incubating/iceberg-rest-service#server-management and https://github.com/apache/gravitino/blob/main/spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/SparkEnvIT.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
