jerryshao commented on code in PR #7361: URL: https://github.com/apache/gravitino/pull/7361#discussion_r2194099868
########## api/src/main/java/org/apache/gravitino/policy/PolicyContent.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.policy; + +import java.util.Map; +import java.util.Objects; +import org.apache.gravitino.exceptions.IllegalPolicyException; + +/** The interface of the content of the policy. */ +public interface PolicyContent { + + /** @return The additional properties of the policy. */ + Map<String, String> properties(); + + /** + * Validates the policy content. + * + * @throws IllegalPolicyException if the content is invalid. + */ + void validate() throws IllegalPolicyException; + + /** + * Creates a custom policy content with the given rules and properties. + * + * @param rules The custom rules of the policy. + * @param properties The additional properties of the policy. + * @return A new instance of {@link PolicyContent} with the specified rules and properties. + */ + static PolicyContent custom(Map<String, Object> rules, Map<String, String> properties) { + return new CustomContent(rules, properties); + } + + /** + * A custom content implementation of {@link PolicyContent} that holds custom rules and + * properties. + */ + class CustomContent implements PolicyContent { Review Comment: There may be some other built-in policy content you should define here. I would suggest you create a new `PolicyContents` to move all the defined class as well as creation methods to that class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
