justinmclean commented on code in PR #7621:
URL: https://github.com/apache/gravitino/pull/7621#discussion_r2196614397
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -774,7 +774,7 @@ static String addIndexDefinition(TableChange.AddIndex
addIndex) {
static String deleteIndexDefinition(
JdbcTable lazyLoadTable, TableChange.DeleteIndex deleteIndex) {
- if (deleteIndex.isIfExists()) {
+ if (!deleteIndex.isIfExists()) {
Preconditions.checkArgument(
Arrays.stream(lazyLoadTable.index())
.anyMatch(index -> index.name().equals(deleteIndex.getName())),
Review Comment:
My understanding is that if isIfExists returns true, then it will ignore any
warnings about non-existent indexes. If it returns false, then you do want to
warn about non-existent indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
